[SOLVED] RGuiAction.getByScriptFile

[smf]

Hi there,

I'm still trying to connect a QToolButton (inside a widget) to a script (see first question at viewtopic.php?f=30&t=3187 which was not solved because I changed the complete concept after understanding the answer to my former second question - now having the same problem again). The following code works:

Code: Select all

widgets["addTrack"]["clicked()"].connect(this, function() { /* do something somewhere else! */ });

but it is not what is wanted - I like to start a script as if the user started it from the menu bar or via short cut.

So I tried

Code: Select all

var button = formWidget.findChild("addTrack");
button.setDefaultAction(RGuiAction.getByScriptFile("scripts/QCTrack/TrackWidgetInsert/TrackWidgetInsert.js"));

which results in null-function (clicking on the button just does nothing, even with debugger enabled), because RGuiAction.getByScriptFile returns null.

Surprisingly

Code: Select all

var button = formWidget.findChild("addTrack");
button.setDefaultAction(RGuiAction.getByScriptFile("scripts/Block/InsertBlock/InsertBlock.js"));

gave me an icon on the button, clicking on it starts the InsertBlock-script.

I'm sorry for asking questions like that, but I can't see any difference. Can you help me out? Is there something that needs to be done inside the script that should be connected?

Thanks in advance,
Stefan

[andrew]

If RGuiAction.getByScriptFile("scripts/QCTrack/TrackWidgetInsert/TrackWidgetInsert.js") returns null, there is no RGuiAction available for that script.

As soon as an action is added to the menu (or another tool button, etc) it 'lives' and can be queried by RGuiAction.getByScriptFile.

If you only need this action for this button, you can create it right there where you need it:

var action = new RGuiAction(qsTr("Text"), RMainWindowQt.getMainWindow());
action.setRequiresDocument(true or false);
action.setScriptFile("scripts/QCTrack/TrackWidgetInsert/TrackWidgetInsert.js");
action.setIcon("scripts/QCTrack/TrackWidgetInsert/TrackWidgetInsert.svg");
action.setStatusTip(...);

Note that RGuiAction objects should only be created once. Once created, the same action should be used behind all user interface components which trigger the action (menus, context menus, buttons, etc.).

[smf]

Thank you Andrew!

There is a menu item for the script, starting the script via short cut also works. At the moment, I see two differences: (1) On QCad start, the script is disabled because no document is existing. (2) I have no icon.

The init function of TrackWidgetInsert is:

Code: Select all

    var action = new RGuiAction(QCTrack.MenuItem.TrackWidgetInsert, RMainWindowQt.getMainWindow());
    action.setRequiresDocument(true);
    action.setScriptFile(basePath + "/TrackWidgetInsert.js");
    action.setDefaultShortcut(new QKeySequence("q,n"));
    action.setGroupSortOrder(QCTrack.MenuOrder.GroupSortOrder);
    action.setSortOrder(QCTrack.MenuOrder.TrackWidgetInsert);
    EAction.addGuiActionTo(action, QCTrack, true, false, false);
    var appWin = EAction.getMainWindow();
    appWin.addSelectionListener(action);

Does this look that bad?

[andrew]

Please check which code is executed first, the action creation or querying the action with RGuiAction.getByScriptFile.

[smf]

The widget that uses the other function is called before (i.e. query before action).

[andrew]

You can try to use postInit instead of init to create your widget.

I.e.

MyClass.postInit = function() {
    ...
};

Or if you have it in a separate file MyClassPostInit.js:

function postInit() {
    ...
}

[smf]

postInit did it. Thanks a lot!

One (little?) thing remaining: the text of the butten is replaced by the icon, but as I don't have one, the button becomes empty. Is there a "good" way to have a text on it?

Again: many thanks, Andrew!

[andrew]

var action = new RGuiAction(...);
action.disableIcon();

By default, actions without an icon are assigned an empty icon. Without any icon, menu entries show check marks beside menu entries on some Linux systems.

[smf]

Thanks again Andrew for the fast help. Disabling the icon will print the full menu item text, so my widget "explodes" in terms of size. But I think I found a "workaround": I will use a mini-function that uses something like

Code: Select all

var action = RGuiAction.getByScriptFile("scripts/Block/EditBlock/EditBlock.js");
if (!isNull(action)) { action.slotTrigger(); }

which I found in BlockList.js - now having RGuiAction working, I just call the other script and make the buttons completely independent.

Perfect support here in the forum, thanks again!

[andrew]

which I found in BlockList.js - now having RGuiAction working, I just call the other script and make the buttons completely independent.

OK. Glad you could solve it.

Some things to keep in mind though: Your button will not be automatically disabled if no document is open. Also if the action requires a selection, the button will not be disabled if there is no selection. This is only the case if the action is the default action of the button.

[smf]

Thanks for the hint!