Offset on full ellipses

[marzof]

Hi,
I noticed that the offset tools on full ellipses is not working on open source version (after disabling pro plugins) of QCAD 3.12.8. I noticed the issue using Linux (Ubuntu) and Windows 7.
The issue doesn't show up on trimmed ellipses.
I think it's related to the ShapeAlgorithms.getOffsetEllipses() function and, notably, it's seems related to the nature of the new entity (being a polyline or a spline).
It seems to me that the lines

Code: Select all

if (isFullEllipseShape(shape)) {
   spl.setPeriodic(true);
}

are the reason of this unexpected behavior since setPeriodic is not a method of polylines.
Am I right?

[andrew]

Moved to QCAD Community Edition forum.

[marzof]

Hi,
in order to solve the bug I made a little change in ShapeAlgorithms.js (scripts folder).
In ShapeAlgorithms.getOffsetEllipses function I replaced the lines

Code: Select all

            if (isFullEllipseShape(shape)) {
                spl.setPeriodic(true);
            }

whit these lines:

Code: Select all

            if (isFullEllipseShape(shape)) {
                if (isSplineShape(spl)) {
                    spl.setPeriodic(true);
                }
                else {         // is Polyline
                    spl.setClosed(true);
                }
            }

I hope it helps.
Bye

[andrew]

Thanks. The fix has been applied.

Bug report:
http://www.qcad.org/bugtracker/index.ph ... sk_id=1399