As we can read in this forum topic:
https://forum.qcad.org/t/tip-when-dealing-with-an-exception-occurred-entity-not-saved-xxxx-error-on-save/11970
The tool can report “Object selected: nnn” when selecting an offending entity while nothing seems to be selected.
The search for the offending entity can be simplified by also reporting its Block name.
if (isEntity(obj)) {
di.selectEntity(obj.getId());
EAction.handleUserMessage(qsTr("Object selected:") + " " + obj.getId() + " (" + obj.getBlockName() + ")");
}
The object ID nnn is of no use for a common user.
Automatically switching to the Block in question is perhaps even better.
In the referred topic the user explains how to find and delete the entity.
It won't be saved thus saving and reopening is then the more simplier solution.
Offending is for example an ellipse with a negative ratio.
Not automatically fixed by correctMajorMinor().
But easily fixed when selected (in the current Block).
Regards,
CVH
If a drawing has layer states, the collapse state of layers that are also in the layer state is not remembered correctly.
Andrew,
Nicely summarized by an AI:
Comparing two floating-point values within a tolerance is NOT
the same as comparing their squared values within the squared tolerance.
Squaring changes the scale of values and the distance between them.
This breaks the linear logic used in standard tolerance checks, especially for values near zero or larger values.
Why These Methods Are Not Equal:
- Different scaling near zero:
If a = 0.1 and b = 0.2, their absolute difference is 0.10.
Their squared values are 0.01 and 0.04, with a difference of 0.03 (three times smaller).
- Different scaling for large values:
If a = 1000.1 and b = 1000.2, their difference is 0.10,
but their squared values differ by about 200 (2000 times larger).
- Tolerance distortion:
A linear tolerance epsilon allows a fixed window [a-epsilon < b < a+epsilon]. Squaring maps this to a non-linear, asymmetric range that grows much faster for larger base values.
When It Fails:
- Small values (<±1):
The squared difference becomes much smaller than the linear difference.
A tolerance that passes linear values might fail squared values.
- Larger values (>±1):
The squared difference becomes much larger than the linear difference.
A tolerance that passes linear values will likely fail squared values.
- Negative values: Squaring loses the sign.
If (a = -1.001) and (b = 1.001), they are far apart linearly,
but their squared values are nearly identical (1.002 vs 1.002).
Recently implemented at various places in QCAD.
For example to compare a distance in XY with a value within tolerance avoiding the
sqrt() of the vector magnitude by retrieving the squared magnitude.
Where the distance d = sqrt(dX²+dY²+dZ²) is compared with a positive value v within a small tolerance (e.g. RS.PointTolerance = 1e-9)
Including dZ because there is no 2D variant for RVector::getSquaredMagnitude().
Or for example where the squared distance is calculated in direct as dSqr = dX²+dY².
Typically worked out as fabs(d - v) < 1e-9 (analog of RMath.fuzzyCompare).
What results in fabs(sqrt(dX²+dY²) - v) < 1e-9.
And then falsely replaced by fabs(dX²+dY² - v²) < 1e-9*1e-9
Or comparing a difference to within 1e-18.
In the case of larger numbers (>1):
Subtracting 2 much larger but near equal values with no more than 17 significant digits.
Also algebraically incorrect ! …
Squaring both sides of (|d - v| < tol) to exploit d² instead of d results in: ((d - v)² < tol²)
And this expands to: (d² - 2dv + v² < tol²) where the root d is still present.
(fabs(d - v) < tol) is already a reduction of a window comparison: (d > v-tol && d < v+tol)
At best, avoiding the subtraction of a small value in floating point: (d+tol > v && d < v+tol)
We then also avoid digit cancellation when subtracting larger values in fabs(d - v).
But squaring this also leads to ((d+tol)² > v²) or (d²+2*d*tol+tol² > v²) for the first test.
With the initial window comparison:
Squaring (d > v-tol && d < v+tol) results in: (d² > (v-tol)² && d² < (v+tol)²)
In wich we can replace d² and the intended value v ≈ sqrt(d²) to compare with:
(dSqr=dX²+dY² > (v-tol)² && dSqr=dX²+dY² < (v+tol)²)
This may fail when (d == v).
And always when tol is too small to be added or subtracted in floating-point.
When comparing (squared) values within a small tolerance we must thus include equality:
if (dSqr >= (v-tol)*(v-tol) && dSqr <= (v+tol)*(v+tol)) {...}
Programmatically more complex …
… and perhaps no longer a faster method than taking the root.
The second test is skipped when the first is true.
It certainly avoids the absurd comparison with 1e-18.
Because that is mostly true for real near equal distances after squaring.
Regards,
CVH
I've noted that on my (relatively) new Mac Mini (M4), when I open my drawings, it yells at me when I open a block about using a "Custom" paper size. it should be "A" size (US-Letter). When I try to set it to ANSI-A (Letter), even after saving, it reverts to "Custom" (though the dimensions remain correct (8.5"x11")
This may be unique to the ARM version but I've noted that with each drawing I open, it flags that I am using a "Custom" page size. My default Printing-Page is ANSI-A (US-Letter). I can save that (Application Preferences)…close the program…open it up and while the page dimensions remain correct, the program still reports it as a "Custom" size.
I see a similar behavior from the Drawing Preferences, with respect to Printing - Page.
I didn't start noticing this behavior until I changed my computer to an M4 based Mac Mini running Tahoe. With that change, I started using the ARM based version of QCAD. So, I'm wondering if the problem is ARM based rather than on other operating systems, including Intel based Macs, like my previous one.
Andrew,
Claude included major/minor swapping in REllipse::getVectorTo().
This is an existent resource and already used in most cases.
I never encountered a major radius less than the minor but it is plausible.
For a ratio over 1.0, correctMajorMinor() caches the minor point (Line 1205).
Sets a corrected ratio (Line 1206).
And then it sets the major point using REllipse::setMajorPoint() (Line 1207).
setMajorPoint() calls REllipse::correctMajorMinor() again.
This time the ratio is less than 1.0 and nothing is altered.
Because correctMajorMinor() is setting things straight it can simply update
the public attributes: 'ratio', 'majorPoint', 'startParam' and 'endParam' in this order.
correctMajorMinor() is typically called for:
- The valid REllipse constructor.
- When setting the REllipse major point, the ratio
and thus also when setting the minor point.
- When setting the properties of an REllipseEntity.
There is a second analog to REllipse::correctMajorMinor().
The method REllipse::switchMajorMinor() does practically the same but then based on an external test.
In open source only used in RShape::getIntersectionPointsEE (Line 1275 and 1279).
Then called when the major radius is less than the minor radius.
The main difference is that it is skipped when the ratio is less than 1e-9.
fabs(ratio) in line 314 is odd because a negative ratio is invalid … Not rendered.
switchMajorMinor() triggers correctMajorMinor() twice.
It first set the major point equal to the minor point based on the former ratio.
This triggers correctMajorMinor().
Then it sets the reciprocal of the ratio.
This also triggers correctMajorMinor().
switchMajorMinor() can also update the public attributes in direct.
For the record: REllipse::getTangents also swaps major/minor in direct when the point is on the minor axis. This method handles an ellipse as full and doesn't correct end parameters.
Regards,
CVH
1. Freeze an empty layer in a viewport
2. Save
3. Reopen
Layer is not frozen.
See also:
https://forum.qcad.org/t/manage-viewport-layers-not-persisting-save-and-reopen/11902