Converting G2 / G3 to start angle / stop angle / radius

Discussions around the CAM Add-On of QCAD.

Moderator: andrew

Jeff66
Junior Member
Posts: 10
Joined: Fri Jul 03, 2020 8:02 am

Converting G2 / G3 to start angle / stop angle / radius

Post by Jeff66 » Tue Jul 14, 2020 10:06 am

Hi everyone

Everything is almost in the subject. I need to convert G2 / G3 to something like
F26 "Start Angle" "Stop Angle" "Radius" (Clockwise)
F27 "Start Angle" "Stop Angle" "Radius" (CCW)

Any usefull tips ?

CVH
Premier Member
Posts: 1378
Joined: Wed Sep 27, 2017 4:17 pm

Re: Converting G2 / G3 to start angle / stop angle / radius

Post by CVH » Tue Jul 14, 2020 3:03 pm

Hi,
What dialect/machine is that? :o
'F', is that not the reserved code for Feed in G-code?
F26 would be: Set Feed to 26units/minute. :wink:

Exporters are configurable, so arc X to your F26/27 won't be a problem.
All the specifics are ready available. (Begin- /End angle, radius, reversed)
Andrew can explain you how.

On the other hand if the source is G-code you'll need to apply some basic trig math. e_geek
R would be sqrt(i²+j²) (and as 'distance' always positive)
G-code is consecutive and only includes the end position.
The End-angle can be found as the angle of the line from the center-point to the endpoint.
The center-point can be found by applying i and j on X and Y.
For the Begin-angle you'll need the final position of the previous command.

A trig pitfall could be the 'G2 or G3 side' where the center is located and the positive radius. :wink:

Hopes this helps a little

Regards,
CVH

Jeff66
Junior Member
Posts: 10
Joined: Fri Jul 03, 2020 8:02 am

Re: Converting G2 / G3 to start angle / stop angle / radius

Post by Jeff66 » Tue Jul 14, 2020 4:24 pm

Hi CVF
Thanks for your reply.

The machine I'm using doesn't understand G-Code. It's a very specifi command made for turning. I wrote a post about it : https://www.qcad.org/rsforum/viewtopic. ... 6f31204df6

You can take a look at the various functions here : http://www.kolly.ch/wp-content/uploads/ ... nglish.pdf

You're almost right with F26 for a controller that understand GCode. On mine it's either F0 to F9 (no space) for pre-set feed values, or F xxx (with a space) wich means Feed at xxx mm/min. F26 / F27 are functions that acts like G2 / G3 with G-Code except that the syntax is F26 "Start angle" "Stop angle" "Radius".

My problem is how to write the postprocessor to translate I/J/IA/JA/RADIUS/DIAMETER/SWEEP to the values that I need.
I wonder if there is existing variables for start / end angle in QCad ? Or if someone could help me with js ?

If you have any idea / tips you're welcome
Jeff

CVH
Premier Member
Posts: 1378
Joined: Wed Sep 27, 2017 4:17 pm

Re: Converting G2 / G3 to start angle / stop angle / radius

Post by CVH » Tue Jul 14, 2020 11:31 pm

I am not a QCAM guy.
Jeff66 wrote:
Tue Jul 14, 2020 4:24 pm
I/J/IA/JA/RADIUS/DIAMETER/SWEEP
Is that what you have to work with?
Not quite standard G-code.

In QCAD & javascript for an RArc entity you have: e_geek
RArc.getCenter()
Rarc.getRadius()
RArc.getStartAngle()
Rarc.getEndAngle()
RArc.isReversed ()
That should cover F26/27

From G2/3 X,Y,I,J the way is pure math and explaind.
I presume the relative version works with I IA J JA.
Strange that you mention and RADIUS, and DIAMETER and on top of that the SWEEP as parameters ...
Or is that the radius form.

Regards,
CVH
Last edited by CVH on Wed Jul 15, 2020 9:04 am, edited 1 time in total.

CVH
Premier Member
Posts: 1378
Joined: Wed Sep 27, 2017 4:17 pm

Re: Converting G2 / G3 to start angle / stop angle / radius

Post by CVH » Wed Jul 15, 2020 8:44 am

Pictures say more then words:
The 'relative' is a big guess. :wink:
CVH
PS Remember to catch the limits of the Atan2 function.
Attachments
G-code2Polar.dxf
(118.26 KiB) Downloaded 107 times

Jeff66
Junior Member
Posts: 10
Joined: Fri Jul 03, 2020 8:02 am

Re: Converting G2 / G3 to start angle / stop angle / radius

Post by Jeff66 » Wed Jul 15, 2020 2:26 pm

Thank you CVH for the drawing, it's very clear and it helps ! :wink:

My main problem is not related to trigonometry and/or understanding GCode and how G2/G3 works. Despite the fact I did some programming in my young ages e_geek , my main issue is I'm not at ease with javascript... :oops: :roll:

Example, I changed the angle to degrees using this :
this.registerVariable("arcSweep", "SWEEP", true, "", "DEFAULT", { factor: 360/Math.PI/2 });

It works. but is it the best way to do it ? Should I have used RMath.rad2deg() instead ? And how ?

Other question, you mentionned Rarc.getStartAngle(). How should I / could I use it in my postprocessor ? Where coud I find resources / explanations about this specific function ?

Generally, is there some documentation on the various CL-data ressources used by QCad ? (Or BTW a good "javascript for dummies" book... :wink: )

Finaly, since my command doesn't understand GCode, I wonder if I'd rather write my postprocessor from scratch rather than starting from a copy of GCodebase. My command is not complicated. The only difficulty I'm having is with my circular interpolation functions. If someone could help me on how to write this in the postprocessor would be very helpfull.

(Either using this RArc.getStartAngle() or using the atan() function) or any other way of getting these start / end angles)

Thanks in advance !
Jeff

User avatar
andrew
Site Admin
Posts: 7735
Joined: Fri Mar 30, 2007 6:07 am

Re: Converting G2 / G3 to start angle / stop angle / radius

Post by andrew » Wed Jul 15, 2020 3:47 pm

For the start angle / end angle of an arc:

In your constructor:

Code: Select all

// define new variables:
this.arcStartAngle = undefined;
this.registerVariable("arcStartAngle", "STARTANGLE", true, "", "DEFAULT", "DEFAULT");
this.arcEndAngle = undefined;
this.registerVariable("arcEndAngle", "ENDANGLE", true, "", "DEFAULT", "DEFAULT");

...
// use new variables for arcs:
this.arcCWMove =  ["... [STARTANGLE] [ENDANGLE] ..."];
this.firstArcCWMove = this.arcCWMove;
this.arcCCWMove =  ["... [STARTANGLE] [ENDANGLE] ..."];
this.firstArcCCWMove = this.arcCCWMove;
Override function "writeEntity":

Code: Select all

MyPostProcessor.prototype.writeEntity = function() {
    // initialize additional variables:
    if (isArcEntity(this.currentEntity)) {
        this.arcStartAngle = this.currentEntity.getStartAngle();
        this.arcEndAngle = this.currentEntity.getEndAngle();
    }
    else {
        this.arcStartAngle = undefined;
        this.arcEndAngle = undefined;
    }

    GCodeBase.prototype.writeEntity.call(this);
};
Lots of assumptions here, but that's basically how you can add entity dependent variables.

CVH
Premier Member
Posts: 1378
Joined: Wed Sep 27, 2017 4:17 pm

Re: Converting G2 / G3 to start angle / stop angle / radius

Post by CVH » Wed Jul 15, 2020 4:03 pm

Wasn't my first question:
Post-processor or G-code translator?

Again I am not a QCAM guy, that is for Andrew.
And he replied just now ... :P
Jeff66 wrote:
Wed Jul 15, 2020 2:26 pm
Generally, is there some documentation on the various CL-data resources used by QCad ? (Or BTW a good "javascript for dummies" book... :wink: )
No, info is scarce. :(
You could try Qcad Classes: :wink:
https://www.qcad.org/doc/qcad/latest/de ... index.html

I can't find a source of GCodebase.js so I am not aware how this script acts ...
Searched 2 drives, the Qcad masters at github and the net.
Jeff66 wrote:
Wed Jul 15, 2020 2:26 pm
{ factor: 360/Math.PI/2 }
{ factor: 180/Math.PI } is one division less for start.
RMath.rad2deg() is about the same as rad2deg().
The plain version is from input.js the other is the standard Math lib parsed as RMath ...
I got the advise from Andrew to not use those from input.js but you can't avoid them everywhere.
Input.js is partially in degrees as I remember.

JavaScript isn't that hard to master a bit. :wink:
What and how to do things under QCAD is more vage. :|

Regards,
CVH

Jeff66
Junior Member
Posts: 10
Joined: Fri Jul 03, 2020 8:02 am

Re: Converting G2 / G3 to start angle / stop angle / radius

Post by Jeff66 » Wed Oct 14, 2020 8:38 am

I did some progress but still have questions.

This is working (thank you Andrew) : this.registerVariable("arcStartAngle", "STARTANGLE", true, "", "DEFAULT", "DEFAULT");
And I can use it like this : this.firstArcCWMove = ["F26 [STARTANGLE] [ENDANGLE] [RADIUS]"];

Now I need to convert STARTANGLE and ENDANGLE in degrees. I tried this in the variable definition but it doesn't work :
this.registerVariable("arcStartAngle", "STARTANGLE", true, "", "DEFAULT", {factor: RMath.rad2deg()});

On the other hand, this is working : this.registerVariable("arcSweep", "SWEEP", true, "", "DEFAULT", { factor: 180/Math.PI });

What am I doing wrong with RMath.rad2deg() ?

Second question, how could I correct STARTANGLE and ENDANGLE for plus or minus a quadrant ? (90 degrees) ?

And last question, I'd like to define a seconf feed rate (feedRate2) that would be half of the normal feed rate for my circular interpolation.

if I do this it works :
this.feedRate2 = 40;
this.registerVariable("feedRate2", "F2", false, "F ", "DEFAULT", "DEFAULT");
this.ArcCWMove = ["F25 [F2!] F26 [STARTANGLE] [ENDANGLE] [RADIUS]"];

but then the feed rate is always 40 (fixed).

If I do this, it doesn't work :
this.feedRate2 = feedRate / 2;

This doesn^t work either :
this.feedRate2 = undefined ;
this.registerVariable("feedRate2", "F2", false, "F ", "DEFAULT", {factor: feedRate / 2});

Can someone help me ?
Thank you in advance.

JF
Last edited by Jeff66 on Wed Oct 14, 2020 10:35 am, edited 1 time in total.

CVH
Premier Member
Posts: 1378
Joined: Wed Sep 27, 2017 4:17 pm

Re: Converting G2 / G3 to start angle / stop angle / radius

Post by CVH » Wed Oct 14, 2020 9:51 am

Hi,

Code: Select all

this.registerVariable("arcStartAngle", "STARTANGLE", true, "", "DEFAULT", "DEFAULT");
What I think happens is:
The parameter arcStartAngle is registered as 'STARTANGLE' so that you can use it as [STARTANGLE]
For that it has to exist first:
Presumed that's why it is declared as 'undefined' upfront.

I don't know what the last "DEFAULT" stands for but you reported that { factor: 360/Math.PI/2 } worked.
Simply RMath.rad2deg(voided) won't return much of a value as factor.

Or one provides the angle in degrees:
this.arcStartAngle = RMath.rad2deg(<the value in radians>);
Or one aplies a factor:
{ factor: 360/Math.PI/2 } or shorter { factor: 180/Math.PI }

Regards,
CVH

CVH
Premier Member
Posts: 1378
Joined: Wed Sep 27, 2017 4:17 pm

Re: Converting G2 / G3 to start angle / stop angle / radius

Post by CVH » Wed Oct 14, 2020 10:02 am

Jeff66 wrote:
Wed Oct 14, 2020 8:38 am
Second question, how could I correct STARTANGLE and ENDANGLE for plus or minus a quadrant ? (90 degrees)
Can you elaborate that further, in a 2D plane any orientation/angle is defined spanning the 4 quadrants.
0 -- 360 or 0 -- 2PI

Regards,
CVH

Jeff66
Junior Member
Posts: 10
Joined: Fri Jul 03, 2020 8:02 am

Re: Converting G2 / G3 to start angle / stop angle / radius

Post by Jeff66 » Wed Oct 14, 2020 10:47 am

In G-Code we use G2/G3 from current position to X/Y as end position and I/J as the arc center position.

On mine it's a bit different. It starts from the current position of the tool. It assumes it is on a circle of radius R. I must specify the starting angle on this circle, and the ending angle, as well as the rotation (CW or CCW).

On QCAD 0 is at 3 o'clock, 180 at 9 o'clock, etc... Let's assume it is shifted from 90 degrees on mine and I need to correct this. Taking into account that if I do a +90 to the angle, I must also do a MOD(360) somewhere.

CVH
Premier Member
Posts: 1378
Joined: Wed Sep 27, 2017 4:17 pm

Re: Converting G2 / G3 to start angle / stop angle / radius

Post by CVH » Wed Oct 14, 2020 1:09 pm

Jeff66 wrote:
Wed Oct 14, 2020 10:47 am
On QCAD 0 is at 3 o'clock
That is by standard in a Cartesian plane. :wink:

+90 degrees shift in a Cartesian plane is CCW, so your zero is at 6 o'clock ?!
Or is it at 12 o'clock >> -90 degrees
Jeff66 wrote:
Wed Oct 14, 2020 10:47 am
I must also do a MOD(360) somewhere.
Depends if the target requires a standarized angle.
An orientation of 372 degrees is merely 12 degrees.
But an arc from 0 to 372 degrees is more as a full circle arc.

I don't know the fancy way like the 'factor:' method.
If you provides the angle in degrees:

Code: Select all

 this.arcStartAngle = RMath.rad2deg(RMath.getNormalizedAngle(<the value in radians> +/- Math.PI/2));
Regards,
CVH

Jeff66
Junior Member
Posts: 10
Joined: Fri Jul 03, 2020 8:02 am

Re: Converting G2 / G3 to start angle / stop angle / radius

Post by Jeff66 » Thu Oct 15, 2020 6:54 am

Thank you CVH. I solved it by changing it on my prototype like this :

if (isArcEntity(this.currentEntity)) {
this.arcStartAngle = (rad2deg(this.currentEntity.getStartAngle()) + 90) % 360;
this.arcEndAngle = (rad2deg(this.currentEntity.getEndAngle()) + 90) % 360;
}

and it works fine.

My last problem is with the feed rate. I need to write it with 3 digits even when it's under 100. Like "075" for 75 mm/min (without ")
How can I add a leading 0 to the feedrate ? Or is there a way to force QCAD/CAM to write numbers on 3 digits ?
Thanks again !
Jeff

CVH
Premier Member
Posts: 1378
Joined: Wed Sep 27, 2017 4:17 pm

Re: Converting G2 / G3 to start angle / stop angle / radius

Post by CVH » Thu Oct 15, 2020 8:17 am

Jeff66 wrote:
Thu Oct 15, 2020 6:54 am
I solved it by changing it on my prototype
Math in degrees, ok. I would stick to radians as long as one can.

There is a thing with the ECMAScript % mod function ... and negative values.
Not certain that arc...Angle always returns a normalized angle.
Jeff66 wrote:
Thu Oct 15, 2020 6:54 am
Or is there a way to force QCAD/CAM to write numbers on 3 digits ?
Not a QCAM guy, would not know.
Jeff66 wrote:
Thu Oct 15, 2020 6:54 am
How can I add a leading 0 to the feedrate ?
ECMAScript has the tendency for strings:

Code: Select all

// With CAM one should always be 110% sure that values are valid !!
// With a valid Feedrate as integer:
var textFeedrate = "000" + <Feedrate>;
textFeedrate = textFeedrate.right(3);
Regards,
CVH

Post Reply

Return to “QCAD/CAM”