opennurbs: IsUnsetPoint has been removed

[Thierry Th]

Hello,
Compiling QCAD against opennurbs v7.11.21285.13001 aborts with the following error:

Code: Select all

math/RSpline.cpp:1051:11: error: no member named 'IsUnsetPoint' in 'ON_3dPoint'
    if (p.IsUnsetPoint()) {
        ~ ^
math/RSpline.cpp:1916:5: warning: 'qSort<QList<double>>' is deprecated: Use std::sort [-Wdeprecated-declarations]
    qSort(keys);
    ^
/usr/local/include/qt5/QtCore/qalgorithms.h:188:1: note: 'qSort<QList<double>>' has been explicitly marked deprecated here
QT_DEPRECATED_X("Use std::sort") inline void qSort(Container &c)
^
/usr/local/include/qt5/QtCore/qglobal.h:294:33: note: expanded from macro 'QT_DEPRECATED_X'
#  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)
                                ^
/usr/local/include/qt5/QtCore/qcompilerdetection.h:675:55: note: expanded from macro 'Q_DECL_DEPRECATED_X'
#    define Q_DECL_DEPRECATED_X(text) __attribute__ ((__deprecated__(text)))

and this is normal because IsUnsetPoint has been removed.

[CVH]

Compiling QCAD against opennurbs v7.11.21285.13001

OK, noted, but can you elaborate on what that has to do with QCAD CE.
And why not use the included opennurbs version:
https://github.com/qcad/qcad/tree/maste ... /opennurbs

Just curious.
Used in RSpline::getPointAt to verify the returned point p on a spline at given position t(0..1).
If IsUnsetPoint is deprecated then I presume all are not 'unset' and thus none are invalid.
And we could return the valid vector RVector(p.x, p.y).
Just a shot in the dark, I know nothing of this stuff.

Regards,
CVH

[Thierry Th]

Hello,

Thanks for your reply.
Actually I'm using the port of QCAD on FreeBSD:
https://www.freshports.org/cad/qcad

I'm not the maintainer of this port, but I know the ports system: when possible, it is recommended to not use the bundled dependencies (like opennurbs), but to prefer depend on a separate package:

- the pre-requisites packages have a maintainer, if some patches are needed they are already applied, and they should be fixed quicker in case of problem;

- they may be shared between several apps.

[CVH]

Thanks for the link but I see some duality ...
The site states "QCad is a professional CAD System" but it is not QCAD Pro at all.
Please read the script headers:
* QCAD is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Funny to see your own contributions back on another site.
FlexPainter, InfoCentroids, DrawFromCSV among others.
Then again ... The first two are definitely QCAD Pro features.
And the third will not handle fit-point splines.
And all the pat files by John and the themes by Pete ...
Right: Open source.

Regards,
CVH