Uneven scaling of Polys

Discussion forum for contributors and developers who are using the QCAD ECMAScript development platform or the C++ plugin interface or who are otherwise looking to contribute to QCAD (translations, documentation, etc).

Moderator: andrew

Post Reply
CVH
Premier Member
Posts: 291
Joined: Wed Sep 27, 2017 4:17 pm
Location: Belgium; Antwerp

Uneven scaling of Polys

Post by CVH » Fri Sep 06, 2019 4:17 pm

Andrew,

Continuing from:
viewtopic.php?t=5566

And as I don't want to interfere on standard scripts.

In Scale.js
Arround lines:

Code: Select all

403     // non-uniform scaling of other entities: 
404     entity.scale(sv, this.focusPoint); 
405     op.addObject(entity, flags); 
We could introduce the program flow as in the include flow dxf.
The math for md, P3, Sagitta'' and Bulge'' with the scaled tangent is in the screengrab.
There are some signs to adapt. Lost in sqauring and square routing.

It is also possible to do this graphically:
The new arc is the arc through the scaled endpoints and tangent at the scaled tangent.
Notice that the new apex point on the scaled tangent is not the same as the scaled apex point.
Visualized in the file New Sagitta.dxf.

I leave it up to you to provide me with an adapted script for scale.js.
You only have to enclose a function call at the correct place and the empty function.
From what I understand that can be between 404 and 405.
but I don't have the complete picture.
In scope should be the Poly and the scaling factors.

The option to do this can later be included in AppPrefs.
For now I only want to it put through a firm testing phase.

Kind regards,
CVH
Attachments
UnevenScaleMath2.png
UnevenScaleMath2.png (50.1 KiB) Viewed 879 times
Scaling Poly Flow.dxf
(129.73 KiB) Downloaded 30 times
New Sagitta.dxf
(162.29 KiB) Downloaded 35 times
QCADpro 3.23.0.0 / win7pro 32 bit / 4GB / 1e generation i7 2.6Ghz / HDD GeForce GT 520

CVH
Premier Member
Posts: 291
Joined: Wed Sep 27, 2017 4:17 pm
Location: Belgium; Antwerp

Re: Uneven scaling of Polys

Post by CVH » Sat Sep 07, 2019 6:18 pm

Getting the hang of it:
Included are:
Adapted Scale.js
> Changes are marked with 'CVH'
Adapted ScaleDialog.ui
> For now without change to AppPreffs for testing
> Only works from the dialog

NOT YET fully tested on all kinds of Polys: So BE AWARE.
Edit: Further testing finished.

I made myself a sidenote about:
Arcs with a sweep larger as +/-50° (=bunch of math) should better be cut in two parts.
Did a lot of trials on that manually with indeed even better results.
If we cut arcs up, I first want to evaluate BiArcs and keeping tangency.

Besides that, for flowing Polys with arcs it is allready a better looking alternative.
Exploding a spline is a good startpoint for testing that.
Or cut a circle up in some random pieces and join as a Poly.
2 copies reveal even more differences.

Regards,
CVH


- = - = - = - = - = -
Erratum: vertical chords faulty.
In test scale.js line 467 should read:

Code: Select all

poly.setBulgeAt(vertId , bulge * a / b);
- = - = - = - = - = -
Attachments
ScaleDialog.ui
(12.23 KiB) Downloaded 32 times
Scale.js
(15.84 KiB) Downloaded 31 times
Last edited by CVH on Mon Sep 16, 2019 12:26 am, edited 2 times in total.
QCADpro 3.23.0.0 / win7pro 32 bit / 4GB / 1e generation i7 2.6Ghz / HDD GeForce GT 520

CVH
Premier Member
Posts: 291
Joined: Wed Sep 27, 2017 4:17 pm
Location: Belgium; Antwerp

Re: Uneven scaling of Polys

Post by CVH » Sun Sep 08, 2019 5:09 am

Here are my first quick tests:
Scaled Cyan underlay are the scaled arc segments as ellips arcs.
> What is the only correct way but ellips arcs can not be part of a polyline.
Scaled Dark red is the standard method that keeps the bulges unchanged.
Scaled Green is the mathematical scaled tangent method.
(off course green :wink:)

The math is fully reversible, re-scaling with the invers factors will result in the original arc apart of some arithmetic accuracy.
My option in the dialog is now coded persitent on.
I'll keep it

Pity to remark I have an annoying experience conserning my wiping endeavor:
https://qcad.org/rsforum/viewtopic.php?t=6528


Regards
Attachments
Scaling Poly-arcs by tangents.dxf
(155.26 KiB) Downloaded 36 times
QCADpro 3.23.0.0 / win7pro 32 bit / 4GB / 1e generation i7 2.6Ghz / HDD GeForce GT 520

CVH
Premier Member
Posts: 291
Joined: Wed Sep 27, 2017 4:17 pm
Location: Belgium; Antwerp

Re: Uneven scaling of Polys

Post by CVH » Mon Sep 09, 2019 9:13 am

Andrew,
I think I am done testing.
Disregarded null-lenght Poly and NULL-Poly.
These should not be attemted to scaled.
Merely trying to select a NULL-poly (= @origin) will lead to an AppCrash.

The math is also not applicable on null-lenght segments that have a value for bulge.
>> this will result in Div0 anyhow.
These bulges are left as they are.

Further, everything turns out correctly. See new version of dxf.
And yes, I now see my math in the screengrab is a bit disambiguous.
luckily it was code correctly in Excel.
Copy, paste, replaced cells refs by vars, correct at first run.

Although, imho the scaling by mouse is faulty in general.
See also may '18, firts paragraph, firts post:
https://qcad.org/rsforum/viewtopic.php?t=5566
It later was declared as intended behaviour.
(can't search specific enough to retreive that)
In any case it will be hard for the user to pick two points in the ether to
provide an intented scaling factor as the result is:
scale = sqrt(dx1^2+dy1^2)/sqrt(dx2^2+dy2^2)
This is math humans are not good at. See new version of dxf.

And finally:
In test scale.js lines 472-475 may be reinstated with again a similar swap of var a and var b.
The math under 'slanted chords' will reduce to that for horizontal chords but it's ways shorter.

Code: Select all

 *** the lines as corrected *** 
...
467   poly.setBulgeAt(vertId , bulge * a / b);
...
473   poly.setBulgeAt(vertId , bulge * b / a);
...
Both are my bads. :oops:

Regards,
CVH
Attachments
Scaling Poly-arcs by tangents.v2.dxf
(224.12 KiB) Downloaded 28 times
QCADpro 3.23.0.0 / win7pro 32 bit / 4GB / 1e generation i7 2.6Ghz / HDD GeForce GT 520

Post Reply

Return to “QCAD Developers and Contributors”